Skip to content

Default logger for projectService has assert on exceptions being logged in tsserver #27443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2018
Merged

Default logger for projectService has assert on exceptions being logged in tsserver #27443

merged 1 commit into from
Oct 1, 2018

Conversation

sheetalkamat
Copy link
Member

@sheetalkamat sheetalkamat commented Sep 28, 2018 •
edited
Loading

Helps catching exceptions when they are only logged in the logger (and aren't assert failures since they would anyways be caught)

@sheetalkamat sheetalkamat merged commit 29dd67e into master Oct 1, 2018
@sheetalkamat sheetalkamat deleted the errorMessageLogger branch October 1, 2018 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanCavanaugh RyanCavanaugh RyanCavanaugh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sheetalkamat @RyanCavanaugh