Multiple improvements to watching with --build option #27062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pecs from ConfigFileSpecs
Partially fixes #26524
…en project invalidates
…erwise combine tsconfig.json
…ays returns array of resolved config file name
…load of the project or resetting builder context
- no need to maintain map from referencing projects to references - When queueing for downstream projects, always handle build order
…ven if not present
…ting project, do it after build for invalidated project is complete
…laration file doesnt change
RyanCavanaugh
approved these changes
Sep 13, 2018
ajafff
reviewed
Sep 14, 2018
| /** | ||
| * Returns the target config filename of a project reference. | ||
| * Note: The file might not exist. | ||
| */ | ||
| function resolveProjectReferencePath(host: ResolveProjectReferencePathHost, ref: ProjectReference): ResolvedConfigFileName; | ||
| function resolveProjectReferencePath(ref: ProjectReference): ResolvedConfigFileName; |
There was a problem hiding this comment.
this is worth documenting as a breaking change. I'll need to update my use of that function or write my own that works for all TypeScript versions I want to support
There was a problem hiding this comment.
@RyanCavanaugh May be I can just revert the api change and make it such that first parameter is any so we don't break others
There was a problem hiding this comment.
Maybe you could just add an overload that takes two parameters and discards the first one. This could be marked @deprecated
sheetalkamat
added a commit
that referenced
this pull request
Sep 14, 2018
sheetalkamat
added a commit
that referenced
this pull request
Sep 15, 2018
…ePathAPIChange Revert the API change to resolveProjectReferencePath introduced in #27062
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26524, #26989