Skip to content

Commit 1d22e03

Browse files
authored
Merge pull request #27100 from Microsoft/revertResolveProjectReferencePathAPIChange
Revert the API change to resolveProjectReferencePath introduced in #27062
2 parents 359930a + d6ffdde commit 1d22e03

File tree

3 files changed

+18
-3
lines changed

3 files changed

+18
-3
lines changed

src/compiler/program.ts

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2820,13 +2820,20 @@ namespace ts {
28202820
};
28212821
}
28222822

2823+
// For backward compatibility
2824+
/** @deprecated */ export interface ResolveProjectReferencePathHost {
2825+
fileExists(fileName: string): boolean;
2826+
}
2827+
28232828
/**
28242829
* Returns the target config filename of a project reference.
28252830
* Note: The file might not exist.
28262831
*/
2827-
// TODO: Does this need to be exposed
2828-
export function resolveProjectReferencePath(ref: ProjectReference): ResolvedConfigFileName {
2829-
return resolveConfigFileProjectName(ref.path);
2832+
export function resolveProjectReferencePath(ref: ProjectReference): ResolvedConfigFileName;
2833+
/** @deprecated */ export function resolveProjectReferencePath(host: ResolveProjectReferencePathHost, ref: ProjectReference): ResolvedConfigFileName;
2834+
export function resolveProjectReferencePath(hostOrRef: ResolveProjectReferencePathHost | ProjectReference, ref?: ProjectReference): ResolvedConfigFileName {
2835+
const passedInRef = ref ? ref : hostOrRef as ProjectReference;
2836+
return resolveConfigFileProjectName(passedInRef.path);
28302837
}
28312838

28322839
/* @internal */

tests/baselines/reference/api/tsserverlibrary.d.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4182,11 +4182,15 @@ declare namespace ts {
41824182
* @returns A 'Program' object.
41834183
*/
41844184
function createProgram(rootNames: ReadonlyArray<string>, options: CompilerOptions, host?: CompilerHost, oldProgram?: Program, configFileParsingDiagnostics?: ReadonlyArray<Diagnostic>): Program;
4185+
/** @deprecated */ interface ResolveProjectReferencePathHost {
4186+
fileExists(fileName: string): boolean;
4187+
}
41854188
/**
41864189
* Returns the target config filename of a project reference.
41874190
* Note: The file might not exist.
41884191
*/
41894192
function resolveProjectReferencePath(ref: ProjectReference): ResolvedConfigFileName;
4193+
/** @deprecated */ function resolveProjectReferencePath(host: ResolveProjectReferencePathHost, ref: ProjectReference): ResolvedConfigFileName;
41904194
}
41914195
declare namespace ts {
41924196
interface EmitOutput {

tests/baselines/reference/api/typescript.d.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4182,11 +4182,15 @@ declare namespace ts {
41824182
* @returns A 'Program' object.
41834183
*/
41844184
function createProgram(rootNames: ReadonlyArray<string>, options: CompilerOptions, host?: CompilerHost, oldProgram?: Program, configFileParsingDiagnostics?: ReadonlyArray<Diagnostic>): Program;
4185+
/** @deprecated */ interface ResolveProjectReferencePathHost {
4186+
fileExists(fileName: string): boolean;
4187+
}
41854188
/**
41864189
* Returns the target config filename of a project reference.
41874190
* Note: The file might not exist.
41884191
*/
41894192
function resolveProjectReferencePath(ref: ProjectReference): ResolvedConfigFileName;
4193+
/** @deprecated */ function resolveProjectReferencePath(host: ResolveProjectReferencePathHost, ref: ProjectReference): ResolvedConfigFileName;
41904194
}
41914195
declare namespace ts {
41924196
interface EmitOutput {

0 commit comments

Comments
 (0)