🤖 User test baselines have changed #27048
Conversation
typescript-bot
force-pushed
the
user-update-20180803
branch
from
689bfc5 to
28ff07e
Compare
| @@ -284,7 +284,7 @@ node_modules/chrome-devtools-frontend/front_end/animation/AnimationModel.js(811, | |||
| node_modules/chrome-devtools-frontend/front_end/animation/AnimationModel.js(811,44): error TS2300: Duplicate identifier 'Request'. | |||
| node_modules/chrome-devtools-frontend/front_end/animation/AnimationScreenshotPopover.js(7,11): error TS2339: Property 'AnimationScreenshotPopover' does not exist on type '{ new (effect?: AnimationEffect, timeline?: AnimationTimeline): Animation; prototype: Animation; }'. | |||
| node_modules/chrome-devtools-frontend/front_end/animation/AnimationScreenshotPopover.js(9,23): error TS2304: Cannot find name 'Image'. | |||
| node_modules/chrome-devtools-frontend/front_end/animation/AnimationScreenshotPopover.js(18,39): error TS2345: Argument of type 'new (width?: number, height?: number) => HTMLImageElement' is not assignable to parameter of type 'Node'. | |||
| node_modules/chrome-devtools-frontend/front_end/animation/AnimationScreenshotPopover.js(18,39): error TS2322: Type 'new (width?: number, height?: number) => HTMLImageElement' is not assignable to type 'Node'. | |||
There was a problem hiding this comment.
Did we get rid of the bad-parameter-specific error message? Seems odd.
There was a problem hiding this comment.
Here's a repro:
declare var ohno: new () => HTMLImageElement;
declare function ff(t: Node): void;
ff(ohno)I'll file a bug, but I'm not sure how bad this is.
There was a problem hiding this comment.
Filed #27049
@weswigham can you decide if this is By Design or not?
There was a problem hiding this comment.
Hm. When we elaborate we don't bother using the override message right now, since we assume we won't trigger the elaboration right at the top. We could pass is thru with a little depth tracking?
| node_modules/debug/src/node.js(26,1): error TS2323: Cannot redeclare exported variable 'colors'. | ||
| node_modules/debug/src/node.js(31,5): error TS2323: Cannot redeclare exported variable 'colors'. | ||
| node_modules/debug/src/node.js(60,39): error TS2345: Argument of type 'string | undefined' is not assignable to parameter of type 'string'. | ||
| node_modules/debug/dist/debug.js(3,100): error TS2539: Cannot assign to '_typeof' because it is not a variable. |
There was a problem hiding this comment.
These changes are probably the result of a major new version but I need to confirm.
There was a problem hiding this comment.
Yes, the code seems entirely different.
I'll accept these baselines for now, but I should probably sweep through at some point and make sure the new errors are mostly good. There's about 40 more than before.
Please review the diff and merge if no changes are unexpected.
You can view the build log here.
cc @weswigham @sandersn @RyanCavanaugh