Don't offer module completions in non-module JS files #27004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One consideration, if the project is a configured project (i.e. has tsconfig or jsconfig) then should we keep going and check the compiler options (even if this is a JS file)? My assumption is that the user has fine-grained enough control over what they want when they're using a config file. |
RyanCavanaugh
force-pushed
the
noJsNewModuleCompletions
branch
from
a66f2cd to
95ba73e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue reported offline - in a JS program, other files having a module indicator is not a strong enough signal that the current file can be arbitrarily converted into a module.