Skip to content

Error for merging multiple enums without initial initializers #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Error for merging multiple enums without initial initializers #27

wants to merge 2 commits into from

Conversation

JsonFreeman
Copy link
Contributor

enum E {
A
}

enum E {
B // Should get an error here for starting a second enum with no initializer
}

Also, you should only look at the second commit (5c3ede7) as the first commit is from a different review (#23)

@CyrusNajmabadi
Copy link
Contributor

I feel like there are two major changes going on here. The first is related to exports, and hte second it the enum change. The enum change looks fine to me. The export change i'm not so clear on.

@JsonFreeman
Copy link
Contributor Author

Yeah this pull request is for the enum change. I had another pull request (PR) #23 for the other part, but couldn't figure out how to exclude it from this PR. So I consider you signed off on this PR.

@JsonFreeman JsonFreeman deleted the enumMerging branch July 16, 2014 20:53
@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants