Find first callable/constructable type in union when appropriate #26895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weswigham
reviewed
Sep 5, 2018
| Type '(a: string, b: number) => string | number' is not assignable to type '(a: string, b: number) => number'. | ||
| Type 'string | number' is not assignable to type 'number'. | ||
| Type 'string' is not assignable to type 'number'. | ||
| Type '(a: string, b: number) => string | number' is not assignable to type '(a: string, b: number) => string'. |
Member
There was a problem hiding this comment.
We could avoid these baseline changes if we choose the last matching invokable instead of the first.
RyanCavanaugh
previously requested changes
Sep 5, 2018
Member
RyanCavanaugh
left a comment
RyanCavanaugh
left a comment
There was a problem hiding this comment.
+1 for finding the last signature
DanielRosenwasser
dismissed
RyanCavanaugh’s stale review
Picking the last type isn't any better, so I don't think it's worth changing the implementation just to maintain baselines. Plus, I would argue picking the first signature is usually more desirable for anonymous arrow types anyway.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26449