fixes #2507 - bad formatting for formatonkey if convertTabsToSpaces === false #2687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
A question about how this is being used: what happens if someone uses |
|
@DanielRosenwasser this is independent of tab ot shift tab. The existing code adjusts the indent position but it only considers that the formatter indents using spaces. The pull request also takes into account the fact that the formatter uses tabs as indentation characters if requested to do so. |
|
Feel free to merge whenever you are ready. |
dbaeumer
added a commit
that referenced
this pull request
Apr 19, 2015
fixes #2507 - bad formatting for formatonkey if convertTabsToSpaces === false
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #2507