Skip to content

Typescript server: bad formatting for formatonkey if convertTabsToSpaces === false #2507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dbaeumer opened this issue Mar 26, 2015 · 2 comments
Closed

Typescript server: bad formatting for formatonkey if convertTabsToSpaces === false #2507

dbaeumer opened this issue Mar 26, 2015 · 2 comments
Assignees
@dbaeumer
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue
Milestone
TypeScript 1.5

Comments

@dbaeumer
Copy link
Member

Configure the format options so that convertTabsToSpaces = false.

Type to insert a new line behind an indented }

Observe: the new line has tabs and spaces. The cursor sits between.
@mhegazy mhegazy added the Bug A bug in TypeScript label Mar 26, 2015
@mhegazy
Copy link
Contributor

mhegazy commented Apr 2, 2015

@dbaeumer can you send a PR

@mhegazy mhegazy added this to the Community milestone Apr 2, 2015
@dbaeumer dbaeumer mentioned this issue Apr 9, 2015
Merged
@dbaeumer
Copy link
Member Author

dbaeumer commented Apr 9, 2015

PR #2687 opened

dbaeumer added a commit that referenced this issue Apr 19, 2015
@dbaeumer
Merge pull request #2687 from dbaeumer/feature/fix2507
62b15de 
fixes #2507 - bad formatting for formatonkey if convertTabsToSpaces === false
@mhegazy mhegazy modified the milestones: TypeScript 1.5, Community Apr 19, 2015
@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Apr 19, 2015
@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dbaeumer dbaeumer

Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue
Projects
None yet
Milestone
TypeScript 1.5
Development

No branches or pull requests
2 participants
@dbaeumer @mhegazy