noUnusedLocals: Destructuring assignment is a write #26365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3,11 +3,15 @@ function f(x = 0) { | |||
| x = 1; | |||
| x++; | |||
| x /= 2; | |||
| ([x] = [1]); | |||
| ({ x } = { x: 1 }); | |||
| ({ x: x } = { x: 1 }); | |||
There was a problem hiding this comment.
I think you need tests for more levels in destructuring (nested object literal)
There was a problem hiding this comment.
shouldnt each test be moved to their own function to guarantee used is getting marked correctly for each expression type usage of x?
There was a problem hiding this comment.
Every one of these tests only writes to x, so we're testing that none of these marks x as used. If a single test failed the baseline would change since x was used.
ajafff
suggested changes
Aug 10, 2018
src/compiler/utilities.ts
Outdated
| } | ||
| case SyntaxKind.ShorthandPropertyAssignment: | ||
| // Assume it's the local variable being accessed, since we don't check public properties for --noUnusedLocals. | ||
| return accessKind(parent.parent); |
There was a problem hiding this comment.
this needs to handle objectAssignmentInitializer as that is always read.
consider adding a test case for that, too.
ghost
force-pushed
the
unusedLocals_destructureAssignment
branch
from
a73413d to
f5cffb5
Compare
|
@sheetalkamat Please re-review |
RyanCavanaugh
approved these changes
Aug 28, 2018
sheetalkamat
approved these changes
Aug 28, 2018
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26345