🤖 User test baselines have changed #26256
Conversation
There was a problem hiding this comment.
Preliminary review turns up 3 things to investigate:
- TEST-results.xml got added.
- Formik's example program lost a lot (all) of its contextual types.
- Lodash has new errors from the circular return type detection.
I assume @weswigham knows about (1). I'm investigating whether (2) is our fault, and (3) is be a result of @ahejlsberg's PR -- but I'm not sure yet if this error is bogus.
| node_modules/lodash/_cloneBuffer.js(7,80): error TS2339: Property 'nodeType' does not exist on type '{ "../../../tests/cases/user/lodash/node_modules/lodash/_cloneBuffer": {}; }'. | ||
| node_modules/lodash/_cloneBuffer.js(4,69): error TS2339: Property 'nodeType' does not exist on type '(buffer: any, isDeep?: boolean | undefined) => any'. | ||
| node_modules/lodash/_cloneBuffer.js(7,80): error TS2339: Property 'nodeType' does not exist on type '{ "../../../tests/cases/user/lodash/node_modules/lodash/_cloneBuffer": (buffer: any, isDeep?: boolean | undefined) => any; }'. | ||
| node_modules/lodash/_cloneBuffer.js(22,14): error TS2577: Return type annotation circularly references itself. |
There was a problem hiding this comment.
This is a new error. Not sure it's legit.
There was a problem hiding this comment.
Later: I think this error is wrong, a result of #26236 combined with (probably) #25732. Here's a minimal repro:
var freeModule = module.nodeType;
var Buffer = module.nodeType ? root.Buffer : undefined// , allocUnsafe = Buffer ? Buffer.allocUnsafe : undefined;
/**
* Creates a clone of `buffer`.
*
* @private
* @param {Buffer} buffer The buffer to clone.
* @param {boolean} [isDeep] Specify a deep clone.
* @returns {Buffer} Returns the cloned buffer.
*/
function cloneBuffer(buffer, isDeep) {
}
module.exports = cloneBuffer;| @@ -0,0 +1,17 @@ | |||
| Exit Code: 1 | |||
| Standard output: | |||
| index.tsx(30,17): error TS7006: Parameter 'values' implicitly has an 'any' type. | |||
There was a problem hiding this comment.
Not sure what is going on here -- these are variables in the test program that were formerly contextually typed. Did we change JSX contextual types? Did formik drop some important part of their types?
There was a problem hiding this comment.
Afaik we haven't futzed with jsx in the last few days, so it's probably formik?
There was a problem hiding this comment.
I'm not so sure. I looked around formik's commits and didn't see anything suspicious. And I when I load up the example, it looks like we're incorrectly putting a no-implicit-any error whenever a parameter gets the contextual type any. I can't repro it with non-JSX code, so maybe it's something to do with JSX?
There was a problem hiding this comment.
Formik didn't change - React did. Their LibraryManagedAttributes impl seems to break formik. :(
There was a problem hiding this comment.
The problem is twofold, but is mostly the inference variant of #26274
| @@ -4466,10 +4466,10 @@ node_modules/chrome-devtools-frontend/front_end/coverage/CoverageModel.js(190,48 | |||
| node_modules/chrome-devtools-frontend/front_end/coverage/CoverageModel.js(191,11): error TS2403: Subsequent variable declarations must have the same type. Variable 'entry' must be of type '[CSSStyleSheetHeader, any[]]', but here has type 'CoverageInfo'. | |||
| node_modules/chrome-devtools-frontend/front_end/coverage/CoverageModel.js(192,11): error TS2345: Argument of type 'CSSStyleSheetHeader' is not assignable to parameter of type '{ contentURL(): string; contentType(): ResourceType; contentEncoded(): Promise<boolean>; requestContent(): Promise<string>; searchInContent(query: string, caseSensitive: boolean, isRegex: boolean): Promise<...>; }'. | |||
| Property '_cssModel' does not exist on type '{ contentURL(): string; contentType(): ResourceType; contentEncoded(): Promise<boolean>; requestContent(): Promise<string>; searchInContent(query: string, caseSensitive: boolean, isRegex: boolean): Promise<...>; }'. | |||
| node_modules/chrome-devtools-frontend/front_end/coverage/CoverageModel.js(197,5): error TS2322: Type '[CSSStyleSheetHeader, any[]][]' is not assignable to type 'CoverageInfo[]'. | |||
There was a problem hiding this comment.
Just the usual: https://www.homestuck.com/problem-sleuth/200
There was a problem hiding this comment.
I just added a36a53b - so hopefully this'll stop after the next update 😛
I configured user and rwc to start generating it; didn't realize we never added it to gitignore and just the npmignore. 😄 Easy to fix. |
Please review the diff and merge if no changes are unexpected.
You can view the build log here.
cc @weswigham @sandersn @mhegazy