Fix circular return type issue #26236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # tests/baselines/reference/recursiveResolveDeclaredMembers.types # tests/baselines/reference/typeGuardsWithInstanceOfByConstructorSignature.types
# Conflicts: # src/compiler/diagnosticMessages.json
sandersn
approved these changes
Aug 6, 2018
This was referenced Aug 7, 2018
This was referenced Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we consistently defer resolving signature return types such that our circularity detection logic can properly catch circular references in return types.
This PR also consolidates a bunch of ad hoc logic we had in place to determine whether a function has a declared or inferred return type. The correct way to determine that now is to use the
getReturnTypeFromAnnotationfunction which returns the declared type orundefinedif the type needs to be inferred from the body (usinggetReturnTypeFromBody). In the process of this consolidation I fixed several issues related to JSDoc@typeannotations.Fixes #26104.