Skip to content

Conversation

@LinusU
Copy link
Contributor

@LinusU LinusU commented Jul 10, 2018

Fixes #25547

@msftclas
Copy link

msftclas commented Jul 10, 2018

CLA assistant check
All CLA requirements met.

@j-oliveras
Copy link
Contributor

@LinusU
Copy link
Contributor Author

LinusU commented Jul 10, 2018

Hmm, I thought that was for src/lib/dom.generated.d.ts and src/lib/webworker.generated.d.ts? But this is touching lib/dom.d.ts and lib/lib.webworker.d.ts 🤔

I'm probably missing something though 😄


edit: I think I've submitted a PR to generated files 😂 working on a PR to TSJS-lib-generator now. If that is the correct approach, feel free to close this 😄

@j-oliveras
Copy link
Contributor

lib/dom.d.ts and lib/lib.webworker.d.ts are generated from src/lib/dom.generated.d.ts and src/lib/webworker.generated.d.ts (and other files). And these are generated from TSJS-lib-generator.

@LinusU
Copy link
Contributor Author

LinusU commented Jul 10, 2018

Got it 👍

Closed in favour of microsoft/TypeScript-DOM-lib-generator#530

@LinusU LinusU closed this Jul 10, 2018
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants