Pass sourceFile to getChildren in getTokenAtPositionWorker (#25505) #25538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#25505) For performance reasons, we should always pass sourceFile to getChildren if available.
ghost
approved these changes
Jul 10, 2018
ghost
merged commit 
|
Thanks! |
|
@Andy-MS Thank you! It's pretty exciting to be a typescript contributor now! ;) |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For performance reasons, we should always pass sourceFile to getChildren, if available.
masterbranchjake runtestslocallyFixes #25505
Note that per suggestion of @DanielRosenwasser and @Andy-MS, this doesn't include a unit test since it's primarily a performance improvement, but if someone feels strongly otherwise, I'm happy to write one.