Fix control flow loop in yield expression #25228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yet again, the fix is to stop using checkExpressionCached.
weswigham
approved these changes
Jun 26, 2018
Member
weswigham
left a comment
weswigham
left a comment
There was a problem hiding this comment.
We could set a global checker bit on entry into getFlowTypeOfReference that causes checkExpressionCached to either throw or quietly not cache. I mean, flowLoopStart already exists, we're just using it to signal resetting flow control (which is what causes the problem), rather than proceeding without a cache - it seems like simply that the concept of caching results during flow control is inherently unstable?
In any case, this is OK.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet again, the fix is to stop using checkExpressionCached. As before, I don't know how to fix checkExpressionCached to not cause these infinite recursions.
Fixes #25149