Skip to content

check return tag in getTypePredicateOfSignature #25130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2018
Merged

check return tag in getTypePredicateOfSignature #25130

merged 1 commit into from
Jun 21, 2018

Conversation

sandersn
Copy link
Member

Fixes #25127

@sandersn sandersn requested review from mhegazy and a user June 21, 2018 18:10
ghost
ghost reviewed Jun 21, 2018
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sandersn
Copy link
Member Author

It would be nice to change the API of Signature and other basic types to remove, or make write-only, properties that should be accessed via the getEffective* functions. That's a huge breaking change to the API that exists solely to make Salsa development easier, though, so I don't think it's worth it.

@sandersn sandersn merged commit a7af92e into master Jun 21, 2018
@sandersn sandersn deleted the jsdoc/type-predicates-in-return-tag branch June 21, 2018 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@mhegazy mhegazy mhegazy approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sandersn @mhegazy