Preserve jsx imports even when the compiler option is not set #24311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...based on feedback from VS Code users. Fixes microsoft#23287
mhegazy
reviewed
May 22, 2018
src/services/organizeImports.ts
Outdated
| @@ -92,7 +92,7 @@ namespace ts.OrganizeImports { | |||
| function removeUnusedImports(oldImports: ReadonlyArray<ImportDeclaration>, sourceFile: SourceFile, program: Program) { | |||
| const typeChecker = program.getTypeChecker(); | |||
| const jsxNamespace = typeChecker.getJsxNamespace(); | |||
| const jsxContext = sourceFile.languageVariant === LanguageVariant.JSX && program.getCompilerOptions().jsx; | |||
| const jsxContext = sourceFile.languageVariant === LanguageVariant.JSX; | |||
There was a problem hiding this comment.
i wounder if a better check here is sourceFile.transformFlags & TransformFlags.ContainsJsx !== 0.. this way we only keep it if we know at least one JSX element exist..
amcasey
changed the title
mhegazy
approved these changes
May 22, 2018
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...based on feedback from VS Code users.
Fixes #23287