Support getting JSDoc comment starting at a FunctionType node #23546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
signatureHelpArrowFunction
branch
from
f8ccc4a to
1718330
Compare
sandersn
requested changes
Apr 20, 2018
Member
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
Seems fine, but I have one question about the early-exit refactoring. (plus one style nit)
| (parent.kind === SyntaxKind.PropertyAssignment || | ||
| parent.kind === SyntaxKind.PropertyDeclaration || | ||
| getNestedModuleDeclaration(parent))) { | ||
| if (!parent) return; |
Member
There was a problem hiding this comment.
why doesn't this miss a lot of tags, for example, when node.kind === SyntaxKind.Parameter on line 1848 and following?
src/compiler/utilities.ts
Outdated
| (getSingleInitializerOfVariableStatementOrPropertyDeclaration(parent.parent.parent) === node || getSourceOfDefaultedAssignment(parent.parent.parent))) { | ||
| if (parent.parent && parent.parent.parent && | ||
| (getSingleVariableOfVariableStatement(parent.parent.parent) | ||
| || getSingleInitializerOfVariableStatementOrPropertyDeclaration(parent.parent.parent) === node |
Member
There was a problem hiding this comment.
should be trailing, not leading, || because of our ASI-avoidance rules.
sandersn
approved these changes
Apr 20, 2018
Member
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
Duh, you reminded me that the only thing with no parent is a source file, which doesn't have tags.
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23529