Revert change to PromiseConstructor in #22772

src/lib/es2015.promise.d.ts

@@ -10,7 +10,7 @@ interface PromiseConstructor {
      * a resolve callback used resolve the promise with a value or the result of another promise,
      * and a reject callback used to reject the promise with a provided reason or error.
      */
-    new <T>(executor: (resolve: [T] extends [void] ? (value?: T | PromiseLike<T>) => void : (value: T | PromiseLike<T>) => void, reject: (reason?: any) => void) => void): Promise<T>;
+    new <T>(executor: (resolve: (value?: T | PromiseLike<T>) => void, reject: (reason?: any) => void) => void): Promise<T>;
 
     /**
      * Creates a Promise that is resolved with an array of results when all of the provided Promises

tests/baselines/reference/defaultExportInAwaitExpression01.types

@@ -3,11 +3,11 @@ const x = new Promise( ( resolve, reject ) => { resolve( {} ); } );
 >x : Promise<{}>
 >new Promise( ( resolve, reject ) => { resolve( {} ); } ) : Promise<{}>
 >Promise : PromiseConstructor
->( resolve, reject ) => { resolve( {} ); } : (resolve: (value: {} | PromiseLike<{}>) => void, reject: (reason?: any) => void) => void
->resolve : (value: {} | PromiseLike<{}>) => void
+>( resolve, reject ) => { resolve( {} ); } : (resolve: (value?: {} | PromiseLike<{}>) => void, reject: (reason?: any) => void) => void
+>resolve : (value?: {} | PromiseLike<{}>) => void
 >reject : (reason?: any) => void
 >resolve( {} ) : void
->resolve : (value: {} | PromiseLike<{}>) => void
+>resolve : (value?: {} | PromiseLike<{}>) => void
 >{} : {}
 
 export default x;

tests/baselines/reference/defaultExportInAwaitExpression02.types

@@ -3,11 +3,11 @@ const x = new Promise( ( resolve, reject ) => { resolve( {} ); } );
 >x : Promise<{}>
 >new Promise( ( resolve, reject ) => { resolve( {} ); } ) : Promise<{}>
 >Promise : PromiseConstructor
->( resolve, reject ) => { resolve( {} ); } : (resolve: (value: {} | PromiseLike<{}>) => void, reject: (reason?: any) => void) => void
->resolve : (value: {} | PromiseLike<{}>) => void
+>( resolve, reject ) => { resolve( {} ); } : (resolve: (value?: {} | PromiseLike<{}>) => void, reject: (reason?: any) => void) => void
+>resolve : (value?: {} | PromiseLike<{}>) => void
 >reject : (reason?: any) => void
 >resolve( {} ) : void
->resolve : (value: {} | PromiseLike<{}>) => void
+>resolve : (value?: {} | PromiseLike<{}>) => void
 >{} : {}
 
 export default x;

tests/baselines/reference/inferenceLimit.types

@@ -21,8 +21,8 @@ export class BrokenClass {
 >Array : T[]
 >MyModule : any
 >MyModel : MyModule.MyModel
->(resolve, reject) => {    let result: Array<MyModule.MyModel> = [];    let populateItems = (order) => {      return new Promise((resolve, reject) => {        this.doStuff(order.id)          .then((items) => {            order.items = items;            resolve(order);          });      });    };    return Promise.all(result.map(populateItems))      .then((orders: Array<MyModule.MyModel>) => {        resolve(orders);      });    } : (resolve: (value: MyModule.MyModel[] | PromiseLike<MyModule.MyModel[]>) => void, reject: (reason?: any) => void) => Promise<void>
->resolve : (value: MyModule.MyModel[] | PromiseLike<MyModule.MyModel[]>) => void
+>(resolve, reject) => {    let result: Array<MyModule.MyModel> = [];    let populateItems = (order) => {      return new Promise((resolve, reject) => {        this.doStuff(order.id)          .then((items) => {            order.items = items;            resolve(order);          });      });    };    return Promise.all(result.map(populateItems))      .then((orders: Array<MyModule.MyModel>) => {        resolve(orders);      });    } : (resolve: (value?: MyModule.MyModel[] | PromiseLike<MyModule.MyModel[]>) => void, reject: (reason?: any) => void) => Promise<void>
+>resolve : (value?: MyModule.MyModel[] | PromiseLike<MyModule.MyModel[]>) => void
 >reject : (reason?: any) => void
 
     let result: Array<MyModule.MyModel> = [];
@@ -40,8 +40,8 @@ export class BrokenClass {
       return new Promise((resolve, reject) => {
 >new Promise((resolve, reject) => {        this.doStuff(order.id)          .then((items) => {            order.items = items;            resolve(order);          });      }) : Promise<{}>
 >Promise : PromiseConstructor
->(resolve, reject) => {        this.doStuff(order.id)          .then((items) => {            order.items = items;            resolve(order);          });      } : (resolve: (value: {} | PromiseLike<{}>) => void, reject: (reason?: any) => void) => void
->resolve : (value: {} | PromiseLike<{}>) => void
+>(resolve, reject) => {        this.doStuff(order.id)          .then((items) => {            order.items = items;            resolve(order);          });      } : (resolve: (value?: {} | PromiseLike<{}>) => void, reject: (reason?: any) => void) => void
+>resolve : (value?: {} | PromiseLike<{}>) => void
 >reject : (reason?: any) => void
 
         this.doStuff(order.id)
@@ -69,7 +69,7 @@ export class BrokenClass {
 
             resolve(order);
 >resolve(order) : void
->resolve : (value: {} | PromiseLike<{}>) => void
+>resolve : (value?: {} | PromiseLike<{}>) => void
 >order : any
 
           });
@@ -99,7 +99,7 @@ export class BrokenClass {
 
         resolve(orders);
 >resolve(orders) : void
->resolve : (value: MyModule.MyModel[] | PromiseLike<MyModule.MyModel[]>) => void
+>resolve : (value?: MyModule.MyModel[] | PromiseLike<MyModule.MyModel[]>) => void
 >orders : MyModule.MyModel[]
 
       });

tests/baselines/reference/modularizeLibrary_NoErrorDuplicateLibOptions1.types

@@ -138,8 +138,8 @@ async function out() {
     return new Promise(function (resolve, reject) {});
 >new Promise(function (resolve, reject) {}) : Promise<{}>
 >Promise : PromiseConstructor
->function (resolve, reject) {} : (resolve: (value: {} | PromiseLike<{}>) => void, reject: (reason?: any) => void) => void
->resolve : (value: {} | PromiseLike<{}>) => void
+>function (resolve, reject) {} : (resolve: (value?: {} | PromiseLike<{}>) => void, reject: (reason?: any) => void) => void
+>resolve : (value?: {} | PromiseLike<{}>) => void
 >reject : (reason?: any) => void
 }
 

tests/baselines/reference/modularizeLibrary_NoErrorDuplicateLibOptions2.types

@@ -138,8 +138,8 @@ async function out() {
     return new Promise(function (resolve, reject) {});
 >new Promise(function (resolve, reject) {}) : Promise<{}>
 >Promise : PromiseConstructor
->function (resolve, reject) {} : (resolve: (value: {} | PromiseLike<{}>) => void, reject: (reason?: any) => void) => void
->resolve : (value: {} | PromiseLike<{}>) => void
+>function (resolve, reject) {} : (resolve: (value?: {} | PromiseLike<{}>) => void, reject: (reason?: any) => void) => void
+>resolve : (value?: {} | PromiseLike<{}>) => void
 >reject : (reason?: any) => void
 }
 

tests/baselines/reference/modularizeLibrary_TargetES5UsingES6Lib.types

@@ -138,8 +138,8 @@ async function out() {
     return new Promise(function (resolve, reject) {});
 >new Promise(function (resolve, reject) {}) : Promise<{}>
 >Promise : PromiseConstructor
->function (resolve, reject) {} : (resolve: (value: {} | PromiseLike<{}>) => void, reject: (reason?: any) => void) => void
->resolve : (value: {} | PromiseLike<{}>) => void
+>function (resolve, reject) {} : (resolve: (value?: {} | PromiseLike<{}>) => void, reject: (reason?: any) => void) => void
+>resolve : (value?: {} | PromiseLike<{}>) => void
 >reject : (reason?: any) => void
 }
 

tests/baselines/reference/usePromiseFinally.types

@@ -5,8 +5,8 @@ let promise1 = new Promise(function(resolve, reject) {})
 >new Promise(function(resolve, reject) {})                .finally : (onfinally?: () => void) => Promise<{}>
 >new Promise(function(resolve, reject) {}) : Promise<{}>
 >Promise : PromiseConstructor
->function(resolve, reject) {} : (resolve: (value: {} | PromiseLike<{}>) => void, reject: (reason?: any) => void) => void
->resolve : (value: {} | PromiseLike<{}>) => void
+>function(resolve, reject) {} : (resolve: (value?: {} | PromiseLike<{}>) => void, reject: (reason?: any) => void) => void
+>resolve : (value?: {} | PromiseLike<{}>) => void
 >reject : (reason?: any) => void
 
                 .finally(function() {});