-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Class emit for ES6 #2333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Class emit for ES6 #2333
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
033a83d
Basic emit for class constructor without static property assignment
d3205ef
Remove redundant sourcemap span and comment. Differentiate between em…
8576282
Emit non-getter/setter member function
1b84f1d
emit get/set member function
890aa4a
test cases for constructor overload, non-static property assignment, …
da12d46
Add tests for extension, type arguments, overload
a0a506b
Emit class declaration with static property assignment
7ee587c
Emit class with export and export default
5683960
Disallow refering to static property in computed property name
0672923
Parse classDeclaration in strict mode code for ES6
800c523
Clean up redundant tests
af05afd
Emit Super as super
13e55ae
Address code review
2a07d3f
Address code review: do not emit default constructor
9bf5a11
Update baselines
c70385c
Update baselines
3bb4b50
Update baselines for symbol
0eeb7ce
Update baselines
2c7ea7f
Update Baselines
e573461
Address code review. Use-before-def check will be added to separate w…
88933d5
Address code review
91c5bae
Address code review
c51983d
Address code review
513b45d
Merge branch 'master' into emitClass
9b3fccd
Address code review; Use for..of and use if-statement
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would always enter strict mode once we're in a class. If that's ES semantics, then that's what we should follow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That will be a breaking change. I have tried running on that mode on RWC and our compiler. Both do have non-strict-mode code in classDeclaration. So, I want to push this version in first. Then, decide if we want to extend this to all classDeclaration later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am surprised that stuff broke. Do you recall what the particular strict mode errors were?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, can we bring this to the design meeting. Technically those classes are broken, and won't work in the future. Do we want to continue 'pretending' they're ok, or should we be up frong about breaking them. Can you also possibly email us the examples of where this breaks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, using
arguments
as a name of parameters. I will send email of what is broken