Class emit for ES6 #2333
Class emit for ES6 #2333
Conversation
…it for below ES6 and above ES6
…getter/setter, method, static method,
| } | ||
| else { | ||
| write("super"); | ||
| Debug.assert(languageVersion < ScriptTarget.ES6) |
There was a problem hiding this comment.
not sure you really need that.. it is the else of the if statement with the same condition. just looks like duplication to me,
| emitTrailingComments(member); | ||
| } | ||
| else if (member.kind === SyntaxKind.GetAccessor || member.kind === SyntaxKind.SetAccessor) { | ||
| var accessors = getAllAccessorDeclarations(node.members, <AccessorDeclaration>member); |
There was a problem hiding this comment.
I'm not convinced you need to get all the accessors and emit them together. I would just have one emit method, for methods and accessors, and just emit the word "get" or "set" if you need to, the same way you emit "static".
|
I've renamed this PR so that we can find it more easily down the line. |
| @@ -3187,7 +3193,9 @@ module ts { | |||
| } | |||
| else { | |||
| write("("); | |||
| emitCommaList(node.arguments); | |||
| if (node.arguments.length) { | |||
There was a problem hiding this comment.
This is actually the only place we do a length check before calling emitCommaList. I don't feel that strongly about it, but it's one of those things that's a little odd to see out of place.
Conflicts: src/compiler/checker.ts src/compiler/diagnosticInformationMap.generated.ts src/compiler/diagnosticMessages.json src/compiler/emitter.ts src/compiler/parser.ts
| @@ -157,6 +157,7 @@ module ts { | |||
| Catch_clause_variable_cannot_have_an_initializer: { code: 1197, category: DiagnosticCategory.Error, key: "Catch clause variable cannot have an initializer." }, | |||
| An_extended_Unicode_escape_value_must_be_between_0x0_and_0x10FFFF_inclusive: { code: 1198, category: DiagnosticCategory.Error, key: "An extended Unicode escape value must be between 0x0 and 0x10FFFF inclusive." }, | |||
| Unterminated_Unicode_escape_sequence: { code: 1199, category: DiagnosticCategory.Error, key: "Unterminated Unicode escape sequence." }, | |||
| A_computed_property_name_cannot_reference_a_static_property: { code: 1200, category: DiagnosticCategory.Error, key: "A computed property name cannot reference a static property" }, | |||
There was a problem hiding this comment.
you do not need this any more.
There was a problem hiding this comment.
Yep. It will be removed in the upcoming commit
Emit classDeclaration natively in ES6. This pull request also set parsing-context for class declaration to be strict mode code if target is es6.
Todo: I will update existed test-cases in ES6 conformance which contains class declaration