Skip to content

correctly parse destructuring in let outside of strict mode #2323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 13, 2015
Merged

correctly parse destructuring in let outside of strict mode #2323

merged 2 commits into from
Mar 13, 2015

Conversation

vladima
Copy link
Contributor

@vladima vladima commented Mar 12, 2015

Fixes #2320

JsonFreeman
JsonFreeman reviewed Mar 13, 2015
View reviewed changes
src/compiler/parser.ts
@@ -2975,6 +2975,11 @@ module ts {
return !scanner.hasPrecedingLineBreak() && isIdentifier()
}

function netTokenIsIdentifierOrStartOfDestructuringOnTheSameLine() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

next

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@JsonFreeman
Copy link
Contributor

👍

vladima added a commit that referenced this pull request Mar 13, 2015
@vladima
Merge pull request #2323 from Microsoft/letConstInDestructuringInNotS…
82a940d 
…trictMode

correctly parse destructuring in let outside of strict mode
@vladima vladima merged commit 82a940d into master Mar 13, 2015
@vladima vladima deleted the letConstInDestructuringInNotStrictMode branch March 13, 2015 20:34
@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Destructuring in let does not parse correctly outside of strict mode
3 participants
@vladima @JsonFreeman @msftclas