Path completions for import types #23082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weswigham
commented
Apr 2, 2018
| @@ -201,14 +201,6 @@ declare namespace FourSlashInterface { | |||
| assertHasRanges(ranges: Range[]): void; | |||
| caretAtMarker(markerName?: string): void; | |||
| completionsAt(markerName: string | ReadonlyArray<string>, completions: ReadonlyArray<string | { name: string, insertText?: string, replacementSpan?: Range }>, options?: CompletionsAtOptions): void; | |||
| completionsAndDetailsAt( | |||
There was a problem hiding this comment.
I removed this from the fourslash .d.ts because I tried to use it then discovered that it doesn't exist at runtime - the verify class doesn't have this member (any more?).
mhegazy
approved these changes
Apr 2, 2018
ghost
reviewed
Apr 2, 2018
| //// } | ||
| ////} | ||
| // @Filename: /node_modules/package/index.ts | ||
| ////export namespace Foo { |
There was a problem hiding this comment.
Path completions shouldn't even need to read the file, so this could just be ////file content not read
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes one of the points brought up in this comment.