Skip to content

Instead of using current time, use predefined time for modification to ensure we can detect changes correctly and arent timing dependent #22526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2018
Merged

Instead of using current time, use predefined time for modification to ensure we can detect changes correctly and arent timing dependent #22526

merged 1 commit into from
Mar 14, 2018

Conversation

sheetalkamat
Copy link
Member

Fixes #22455

@sheetalkamat sheetalkamat mentioned this pull request Mar 14, 2018
Closed
weswigham
weswigham approved these changes Mar 14, 2018
View reviewed changes
Copy link
Member

@weswigham weswigham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

@sheetalkamat
Instead of using current time, use predefined time for modification t…
d8fe6ed 
…o ensure we can detect changes correctly and arent timing dependent

Fixes #22455
@sheetalkamat sheetalkamat merged commit 60501c8 into master Mar 14, 2018
@sheetalkamat sheetalkamat deleted the testModifiedTime branch March 14, 2018 00:06
@sheetalkamat sheetalkamat mentioned this pull request Mar 29, 2018
Merged
@microsoft microsoft locked and limited conversation to collaborators Jul 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@weswigham weswigham weswigham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sheetalkamat @weswigham