Add a status request-response for editors #20465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
May be would be a good idea to add test for this api in tsserverProjectSystem that checks on this command session returns ts.version |
ghost
approved these changes
Dec 5, 2017
src/server/protocol.ts
Outdated
| @@ -216,6 +217,27 @@ namespace ts.server.protocol { | |||
| projectFileName?: string; | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
All of the *Request interfaces "request xxx information from the server" so I would just omit the comment.
src/server/protocol.ts
Outdated
|
|
||
| export interface StatusResponseBody { | ||
| /** | ||
| * the version of the currently-running server. |
There was a problem hiding this comment.
Nit: We don't version the server independently of TypeScript as a whole (like we do with services) -- so I would say "The TypeScript version (ts.version)"
|
@sheetalkamat I didn't find a reasonable spot to put the test in |
sheetalkamat
approved these changes
Dec 6, 2017
ghost
approved these changes
Dec 6, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The response gives the tsserver version, needed for telemetry.