Change "isThisless" predicates to "mayReferenceThis" predicates #20036
Conversation
ghost
requested a review
from 
ghost
mentioned this pull request
|
Why would we change this? |
|
It's easier to think about, "a function references this if some parameter does", than "a function is this-less if there isn't any non-this-less parameter". |
src/compiler/checker.ts
Outdated
| case SyntaxKind.Constructor: { | ||
| // A function-like declaration references `this` if its return type does or some parameter / type parameter does. | ||
| const fn = declaration as MethodDeclaration | MethodSignature | ConstructorDeclaration; | ||
| return (declaration.kind !== SyntaxKind.Constructor && typeMayReferenceThis(getEffectiveReturnTypeNode(fn))) |
There was a problem hiding this comment.
if getEffectiveReturnTypeNode returns undefined for nodes with SyntaxKind.Constructor, then you can skip the kind check here.
src/compiler/checker.ts
Outdated
| /** A type parameter is thisless if its contraint is thisless, or if it has no constraint. */ | ||
| function isThislessTypeParameter(node: TypeParameterDeclaration) { | ||
| return !node.constraint || isThislessType(node.constraint); | ||
| return true; |
There was a problem hiding this comment.
should probably reference #20034 here too, because there are plenty of type nodes that could be inspected for this more closely.
|
Can we not merge this until we have actually discussed it? |
|
@Andy-MS @sandersn Please revert this back to the way it was. These functions were designed to return |
ghost
mentioned this pull request
From code review on #19655