Skip to content

Improve testing for symbol that may reference this #20034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ghost opened this issue Nov 15, 2017 · 3 comments
Closed

Improve testing for symbol that may reference this #20034

ghost opened this issue Nov 15, 2017 · 3 comments
Labels
Infrastructure Issue relates to TypeScript team infrastructure

Comments

@ghost
Copy link

ghost commented Nov 15, 2017 •
edited by ghost
Loading

TypeScript Version: 2.7.0-dev.20171115

See comments with text // TODO: GH#20034 (added in #20036).
@sandersn sandersn mentioned this issue Nov 15, 2017
Merged
@mhegazy
Copy link
Contributor

mhegazy commented Nov 16, 2017

so what is the issue here?

@mhegazy mhegazy added the Needs More Info The issue still hasn't been fully clarified label Nov 16, 2017
@ghost
Copy link
Author

ghost commented Nov 16, 2017

The issue is that some node types are ignored, so we're being overly pessimistic. For example, anything with a getter is assumed to use a this type, just because we haven't handled that syntax kind yet.

@mhegazy mhegazy added Infrastructure Issue relates to TypeScript team infrastructure and removed Needs More Info The issue still hasn't been fully clarified labels Nov 17, 2017
@weswigham
Copy link
Member

I can see no more references to #20034 in our codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Infrastructure Issue relates to TypeScript team infrastructure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@weswigham @mhegazy