Skip to content

Add very error-ful checkJS test for chrome devtools js #19992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

weswigham
Copy link
Member

@weswigham weswigham commented Nov 13, 2017

This should help us get some checkJs coverage on a project that has some seriously complete jsdoc (as it's validated under closure compiler's strictest mode).

On that note, this depends on #19980 (since it triggers it), and contains errors which are examples of #19990, #19988, #19987, #19986, #19985, #19983, #19982, and #19981. Because those are all parse errors (we probably shouldn't let jsdoc parse errors block semantic analysis), we don't even actually know any type errors that may or may not be correct yet.

Copy link
Contributor

@mhegazy mhegazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a lot of jsdoc parse errors ..

@weswigham
Copy link
Member Author

@mhegazy Indeed. I also found #20000 using discord.js's source (which I plan to add - it's pretty well structured and uses classes while also using common commonjs patterns, and it gives us a chance to verify the js as we understand it against the .d.ts). Also, I opened #19999 to discuss swallowing jsdoc parse errors unless some kind of --ultraStrictJSDoc flag is passed.

@weswigham weswigham merged commit 98112d4 into microsoft:master Nov 16, 2017
@weswigham weswigham deleted the add-chrome-devtools-as-checkjs-test branch November 16, 2017 19:02
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants