Skip to content

Fix crash on non-dts-require #19980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2017
Merged

Fix crash on non-dts-require #19980

merged 1 commit into from
Nov 14, 2017

Conversation

weswigham
Copy link
Member

@weswigham weswigham commented Nov 13, 2017 •
edited
Loading

We were crashing when a JS file contained a require whose reference looked like it may be a commonjs require, but did not refer to the global require symbol. Likely introduced by cc2a2a7, so it hasn't been broken long. Found while trying to add a checkJs user test.

@weswigham weswigham requested review from mhegazy and a user November 13, 2017 21:44
@weswigham weswigham mentioned this pull request Nov 13, 2017
Merged
@weswigham weswigham merged commit 7d93434 into microsoft:master Nov 14, 2017
@weswigham weswigham deleted the no-crash-on-parameter-named-require branch November 14, 2017 00:41
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mhegazy mhegazy mhegazy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weswigham @mhegazy