Added empty constructors to TypedArrays from es2017 #19739
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhegazy
reviewed
Nov 6, 2017
| @@ -141,6 +141,7 @@ namespace ts { | |||
| "es2017.sharedmemory": "lib.es2017.sharedmemory.d.ts", | |||
| "es2017.string": "lib.es2017.string.d.ts", | |||
| "es2017.intl": "lib.es2017.intl.d.ts", | |||
| "es2017.typedarrays": "lib.es2017.typedarrays.d.ts", | |||
There was a problem hiding this comment.
mind updating it in https://github.com/Microsoft/TypeScript-Handbook/blob/master/pages/Compiler%20Options.md as well.
There was a problem hiding this comment.
|
merged manually. thanks! |
mhegazy
reviewed
Nov 6, 2017
| @@ -0,0 +1,12 @@ | |||
| // @target: es5 | |||
There was a problem hiding this comment.
for future reference, no need for the tests for changes to lib like these.
There was a problem hiding this comment.
I took it from neighbor files in tests/cases/conformance/es2017 but I will keep it on mind
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19680