Add CompletionDetailsFull request #19689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
mhegazy
approved these changes
Nov 2, 2017
|
//cc @amcasey |
|
@amcasey can you give this a quick try |
|
@Andy-MS we need to port this to release-2.6 as well. |
mhegazy
reviewed
Nov 2, 2017
| @@ -4846,6 +4846,7 @@ declare namespace ts.server.protocol { | |||
| Close = "close", | |||
| Completions = "completions", | |||
| CompletionDetails = "completionEntryDetails", | |||
| CompletionDetailsFull = "completionEntryDetailsFull", | |||
|
Waiting for approval from @amcasey |
mhegazy
approved these changes
Nov 3, 2017
|
Please port to release-2.6 as well. |
ghost
pushed a commit
that referenced
this pull request
Nov 3, 2017
* Add CompletionDetailsFull request * Update API baselines * Make internal
ghost
mentioned this pull request
ghost
pushed a commit
that referenced
this pull request
Nov 3, 2017
amcasey
reviewed
Nov 6, 2017
| @@ -15,6 +15,8 @@ namespace ts.server.protocol { | |||
| /* @internal */ | |||
| CompletionsFull = "completions-full", | |||
| CompletionDetails = "completionEntryDetails", | |||
| /* @internal */ | |||
| CompletionDetailsFull = "completionEntryDetailsFull", | |||
There was a problem hiding this comment.
I think the usual convention is -full, rather than Full.
There was a problem hiding this comment.
that is an oversight, we should fix it.
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mhegazy mentioned that this would be necessary for using the code actions from Visual Studio.