Skip to content

Fix supportedMethods property type #19201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix supportedMethods property type #19201

wants to merge 1 commit into from

Conversation

1000ch
Copy link

@1000ch 1000ch commented Oct 16, 2017

@kitsonk
Copy link
Contributor

kitsonk commented Oct 16, 2017

This is not the proper way to contribute to these files.

As mentioned in the README in this directory:

Read This!

These files are not meant to be edited by hand.
If you need to make modifications, the respective files should be changed within the repository's top-level src directory.
Running jake LKG will then appropriately update the files in this directory.

And in the CONTRIBUTING.md:

Contributing lib.d.ts fixes

The library sources are in: src/lib

Library files in built/local/ are updated by running

jake

The files in lib/ are used to bootstrap compilation and usually do not need to be updated.

src/lib/dom.generated.d.ts and src/lib/webworker.generated.d.ts

These two files represent the DOM typings and are auto-generated. To make any modifications to them, please submit a PR to https://github.com/Microsoft/TSJS-lib-generator

@1000ch
Copy link
Author

1000ch commented Oct 16, 2017

@kitsonk Fixed 🙏

@kitsonk
Copy link
Contributor

kitsonk commented Oct 16, 2017

@1000ch again... from the above:

src/lib/dom.generated.d.ts and src/lib/webworker.generated.d.ts

These two files represent the DOM typings and are auto-generated. To make any modifications to them, please submit a PR to https://github.com/Microsoft/TSJS-lib-generator

@1000ch
Copy link
Author

1000ch commented Oct 16, 2017

@kitsonk Ahh, sorry again.

@1000ch 1000ch closed this Oct 16, 2017
@1000ch 1000ch deleted the fix-PaymentMethodData branch October 16, 2017 10:19
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants