Skip to content

Wrong type interface: PaymentMethodData #19200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1000ch opened this issue Oct 16, 2017 · 2 comments · Fixed by #20177
Closed

Wrong type interface: PaymentMethodData #19200

1000ch opened this issue Oct 16, 2017 · 2 comments · Fixed by #20177
Assignees
@mhegazy
Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Fixed A PR has been merged for this issue Help Wanted You can do this
Milestone
TypeScript 2.7

Comments

@1000ch
Copy link

1000ch commented Oct 16, 2017 

interface PaymentMethodData {
    data?: any;
    supportedMethods?: string[];
}

should be

interface PaymentMethodData {
    data?: any;
    supportedMethods?: string;
}

according to https://www.w3.org/TR/payment-request/#paymentmethoddata-dictionary.
@1000ch 1000ch mentioned this issue Oct 16, 2017
Closed
@mhegazy mhegazy added Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Help Wanted You can do this labels Oct 16, 2017
@mhegazy mhegazy added this to the Community milestone Oct 16, 2017
@mhegazy
Copy link
Contributor

mhegazy commented Oct 16, 2017

PRs welcomed. You can find more information about contributing lib.d.ts fixes at https://github.com/Microsoft/TypeScript/blob/master/CONTRIBUTING.md#contributing-libdts-fixes.

john-patterson added a commit to john-patterson/TSJS-lib-generator that referenced this issue Nov 3, 2017
@john-patterson
fix #19200 PaymentMethodData.supportedMethods
c502b9f 
This addresses TypeScript issue microsoft/TypeScript#19200. As per https://www.w3.org/TR/payment-request/#paymentmethoddata-dictionary, supportedMethods was changed from an array to a string, but the name was left plural.
@john-patterson john-patterson mentioned this issue Nov 3, 2017
Merged
@mhegazy mhegazy modified the milestones: Community, TypeScript 2.7 Nov 3, 2017
@mhegazy mhegazy added the Fixed in TSJS repo Fix merged in https://github.com/Microsoft/TSJS-lib-generator, but not ported yet label Nov 3, 2017
@mhegazy mhegazy self-assigned this Nov 3, 2017
@1000ch
Copy link
Author

1000ch commented Nov 4, 2017

My mistake, should not drop old spec immediately.

interface PaymentMethodData {
    data?: any;
    supportedMethods?: string | string[];
}

Fixed on microsoft/TypeScript-DOM-lib-generator#320

@mhegazy mhegazy mentioned this issue Nov 21, 2017
Merged
@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Nov 21, 2017
@mhegazy mhegazy removed the Fixed in TSJS repo Fix merged in https://github.com/Microsoft/TSJS-lib-generator, but not ported yet label Nov 21, 2017
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mhegazy mhegazy

Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Fixed A PR has been merged for this issue Help Wanted You can do this
Projects
None yet
Milestone
TypeScript 2.7
Development

Successfully merging a pull request may close this issue.

Port generated lib files microsoft/TypeScript
2 participants
@1000ch @mhegazy