Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this comment, I supposed that if we were concerned about the overhead of
NodeLinks
, we could reduce or remove it by inverting the shape of our cache structure. This is that.This comparison was captured over 10 iterations on my machine (with a scanner exception for
node
and forced high power mode, as is usual for a windows machine):There is consistently lower memory usage (since just add entries to spare arrays rather than allocate objects), and possible check time savings, too (since we no longer use a polymorphic
NodeLinks
object).I'll try applying the same technique to
SymbolLinks
and see what the improvement there is.