Make it a noImplicitAny error to fail to provide type arguments to a superclass via @augments #18778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
sandersn
requested changes
Sep 27, 2017
src/compiler/diagnosticMessages.json
Outdated
| @@ -3511,6 +3511,14 @@ | |||
| "category": "Error", | |||
| "code": 8021 | |||
| }, | |||
| "Generic type '{0}' requires '{1}' type arguments; provide these with an '@augments' or '@extends' tag.": { | |||
There was a problem hiding this comment.
I'd choose one of @augments or @extends for the error, preferably the one that is in the source if it is already there.
There was a problem hiding this comment.
There probably won't be one already there; we might just recommend @extends since that's the more intuitive name.
| ==== /b.js (1 errors) ==== | ||
| class B extends A {} | ||
| ~ | ||
| !!! error TS8022: Generic type 'A<T>' requires '1' type arguments; provide these with an '@augments' or '@extends' tag. |
There was a problem hiding this comment.
Can you add a test for
/** @augments A */
class B { }There should be an error on A on the first line, I think.
There was a problem hiding this comment.
Requires getting #18775 in first.
sandersn
approved these changes
Oct 20, 2017
src/compiler/diagnosticMessages.json
Outdated
| "category": "Error", | ||
| "code": 8025 | ||
| }, | ||
| "Generic type '{0}' requires between '{1}' and '{2}' type arguments; provide these with an '@extends' tag.": { |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17073
Diagnostic message mentions
@extendsin anticipation of #18706