Skip to content

A function should be context-sensitive if its return expression is #17697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
4 commits merged into from
Aug 10, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions src/compiler/checker.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8405,16 +8405,17 @@ namespace ts {
if (forEach(node.parameters, p => !getEffectiveTypeAnnotationNode(p))) {
return true;
}
// For arrow functions we now know we're not context sensitive.
if (node.kind === SyntaxKind.ArrowFunction) {
return false;
if (node.kind !== SyntaxKind.ArrowFunction) {
// If the first parameter is not an explicit 'this' parameter, then the function has
// an implicit 'this' parameter which is subject to contextual typing.
const parameter = firstOrUndefined(node.parameters);
if (!(parameter && parameterIsThisKeyword(parameter))) {
return true;
}
}
// If the first parameter is not an explicit 'this' parameter, then the function has
// an implicit 'this' parameter which is subject to contextual typing. Otherwise we
// know that all parameters (including 'this') have type annotations and nothing is
// subject to contextual typing.
const parameter = firstOrUndefined(node.parameters);
return !(parameter && parameterIsThisKeyword(parameter));

// TODO(anhans): A block should be context-sensitive if it has a context-sensitive return value.
return node.body.kind === SyntaxKind.Block ? false : isContextSensitive(node.body);
}

function isContextSensitiveFunctionOrObjectLiteralMethod(func: Node): func is FunctionExpression | ArrowFunction | MethodDeclaration {
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
//// [contextualTypingFunctionReturningFunction2.ts]
declare function f(n: number): void;
declare function f(cb: () => (n: number) => number): void;

f(() => n => n);


//// [contextualTypingFunctionReturningFunction2.js]
f(function () { return function (n) { return n; }; });
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
=== tests/cases/compiler/contextualTypingFunctionReturningFunction2.ts ===
declare function f(n: number): void;
>f : Symbol(f, Decl(contextualTypingFunctionReturningFunction2.ts, 0, 0), Decl(contextualTypingFunctionReturningFunction2.ts, 0, 36))
>n : Symbol(n, Decl(contextualTypingFunctionReturningFunction2.ts, 0, 19))

declare function f(cb: () => (n: number) => number): void;
>f : Symbol(f, Decl(contextualTypingFunctionReturningFunction2.ts, 0, 0), Decl(contextualTypingFunctionReturningFunction2.ts, 0, 36))
>cb : Symbol(cb, Decl(contextualTypingFunctionReturningFunction2.ts, 1, 19))
>n : Symbol(n, Decl(contextualTypingFunctionReturningFunction2.ts, 1, 30))

f(() => n => n);
>f : Symbol(f, Decl(contextualTypingFunctionReturningFunction2.ts, 0, 0), Decl(contextualTypingFunctionReturningFunction2.ts, 0, 36))
>n : Symbol(n, Decl(contextualTypingFunctionReturningFunction2.ts, 3, 7))
>n : Symbol(n, Decl(contextualTypingFunctionReturningFunction2.ts, 3, 7))

Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
=== tests/cases/compiler/contextualTypingFunctionReturningFunction2.ts ===
declare function f(n: number): void;
>f : { (n: number): void; (cb: () => (n: number) => number): void; }
>n : number

declare function f(cb: () => (n: number) => number): void;
>f : { (n: number): void; (cb: () => (n: number) => number): void; }
>cb : () => (n: number) => number
>n : number

f(() => n => n);
>f(() => n => n) : void
>f : { (n: number): void; (cb: () => (n: number) => number): void; }
>() => n => n : () => (n: number) => number
>n => n : (n: number) => number
>n : number
>n : number

Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
tests/cases/compiler/contextualTypingWithFixedTypeParameters1.ts(2,22): error TS2339: Property 'foo' does not exist on type 'string'.
tests/cases/compiler/contextualTypingWithFixedTypeParameters1.ts(3,32): error TS2339: Property 'foo' does not exist on type 'string'.
tests/cases/compiler/contextualTypingWithFixedTypeParameters1.ts(3,38): error TS2345: Argument of type '1' is not assignable to parameter of type 'string'.
tests/cases/compiler/contextualTypingWithFixedTypeParameters1.ts(3,32): error TS2339: Property 'foo' does not exist on type '""'.
tests/cases/compiler/contextualTypingWithFixedTypeParameters1.ts(3,38): error TS2345: Argument of type '1' is not assignable to parameter of type '""'.


==== tests/cases/compiler/contextualTypingWithFixedTypeParameters1.ts (3 errors) ====
var f10: <T>(x: T, b: () => (a: T) => void, y: T) => T;
f10('', () => a => a.foo, ''); // a is string
f10('', () => a => a.foo, ''); // a is ""
~~~
!!! error TS2339: Property 'foo' does not exist on type 'string'.
var r9 = f10('', () => (a => a.foo), 1); // error
~~~
!!! error TS2339: Property 'foo' does not exist on type 'string'.
!!! error TS2339: Property 'foo' does not exist on type '""'.
~
!!! error TS2345: Argument of type '1' is not assignable to parameter of type 'string'.
!!! error TS2345: Argument of type '1' is not assignable to parameter of type '""'.
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
//// [contextualTypingWithFixedTypeParameters1.ts]
var f10: <T>(x: T, b: () => (a: T) => void, y: T) => T;
f10('', () => a => a.foo, ''); // a is string
f10('', () => a => a.foo, ''); // a is ""
var r9 = f10('', () => (a => a.foo), 1); // error

//// [contextualTypingWithFixedTypeParameters1.js]
var f10;
f10('', function () { return function (a) { return a.foo; }; }, ''); // a is string
f10('', function () { return function (a) { return a.foo; }; }, ''); // a is ""
var r9 = f10('', function () { return (function (a) { return a.foo; }); }, 1); // error
22 changes: 11 additions & 11 deletions tests/cases/compiler/contextualTypingFunctionReturningFunction.ts
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
interface I {
a(s: string): void;
b(): (n: number) => void;
}
declare function f(i: I): void;
f({
a: s => {},
b: () => n => {},
});
interface I {
a(s: string): void;
b(): (n: number) => void;
}

declare function f(i: I): void;

f({
a: s => {},
b: () => n => {},
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
declare function f(n: number): void;
declare function f(cb: () => (n: number) => number): void;

f(() => n => n);
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
var f10: <T>(x: T, b: () => (a: T) => void, y: T) => T;
f10('', () => a => a.foo, ''); // a is string
f10('', () => a => a.foo, ''); // a is ""
var r9 = f10('', () => (a => a.foo), 1); // error