Deduplicate unresolvedImports #17248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
rbuckton
suggested changes
Aug 8, 2017
src/compiler/core.ts
Outdated
| @@ -373,11 +373,11 @@ namespace ts { | |||
| return false; | |||
| } | |||
|
|
|||
| export function filterMutate<T>(array: T[], f: (x: T) => boolean): void { | |||
| export function filterMutate<T>(array: T[], f: (x: T, i: number) => boolean): void { | |||
There was a problem hiding this comment.
If you align more closely with Array.prototype.filter and use (x: T, i: number, array: T[]) => boolean, then you can remove the closure in toDeduplicatedSortedArray by extracting it into a reusable function:
function isNonDuplicate<T>(value: T, index: number, array: T[]) {
return i === 0 || value !== array[index - 1];
}
src/server/utilities.ts
Outdated
| @@ -201,6 +201,12 @@ namespace ts.server { | |||
| return arr as SortedArray<T>; | |||
| } | |||
|
|
|||
| export function toDeduplicatedSortedArray(arr: string[]): SortedArray<string> { | |||
| arr.sort(); | |||
| filterMutate(arr, (em, i) => em !== arr[i - 1]); | |||
There was a problem hiding this comment.
check that i is non-zero or you deoptimize access to the array.
rbuckton
approved these changes
Aug 8, 2017
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking through some typings installer logs, I noticed the same types modules repeated many times in unresolvedImports. Since they're already sorted, it's easy to deduplicate them.