Fix #17023 #17180
Merged
Fix #17023 #17180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/compiler/checker.ts
Outdated
| function getBindingElementNameText(element: BindingElement): string | undefined { | ||
| if (element.parent.kind === SyntaxKind.ObjectBindingPattern) { | ||
| const name = element.propertyName || element.name; | ||
| if (isComputedNonLiteralName(name as PropertyName)) return undefined; |
There was a problem hiding this comment.
Consider moving this down to the analogous case clause to make it clearer that it's safe to assert name.expression as LiteralExpression
|
Can you make sure that performance doesn't get worse with this change? This would only apply for code bases that use binding patterns, of course, so I guess our own compiler would be a good test case. Maybe? |
sandersn
requested changes
Jul 17, 2017
src/compiler/checker.ts
Outdated
| if (node.kind === SyntaxKind.BindingElement) { | ||
| const key = node.parent.parent.kind === SyntaxKind.BindingElement ? getFlowCacheKey(node.parent.parent) : isApparentTypePosition(node.parent.parent) ? "@<initializer>" : "<initializer>"; | ||
| const text = getBindingElementNameText(node as BindingElement); | ||
| return key && text && key + "." + text; |
There was a problem hiding this comment.
it sounds like from our discussion at lunch that you came up with a better way to make a key.
|
@sandersn I've done my work to find a better cache key (now it follows the same trail Master, de9a67f: Together: So... no difference. |
sandersn
approved these changes
Jul 18, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17023 - binding patterns correctly have their initial type bound to the narrowed type of the narrowed property indicated by the binding pattern. Previously, we were not getting their flow type when looking for their initial type (and the flow logic wasn't setup to look for references equivalent to a nested binding element).