Inline childFromLineNumber and childFromCharOffset #17018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
|
@sheetalkamat PR is ready now. |
rbuckton
reviewed
Aug 7, 2017
src/server/scriptVersionCache.ts
Outdated
| zeroBasedColumn: childInfo.relativePosition, | ||
| lineText: childInfo.child.text, | ||
| }; | ||
| Debug.assert(this.children.length !== 0); |
There was a problem hiding this comment.
Is it guaranteed that children will never be empty when this is called? The previous logic had a specific case to handle that (returning child as undefined from childFromCharOffset).
There was a problem hiding this comment.
It looks like that is possible for a LineNode to have 0 children if this document is the empty string. Added a test.
|
Your test is failing. |
|
Fixed. |
rbuckton
approved these changes
Aug 9, 2017
uniqueiniquity
pushed a commit
to uniqueiniquity/TypeScript
that referenced
this pull request
Aug 9, 2017
* Inline childFromLineNumber and childFromCharOffset * Handle empty document -- root node with 0 children * Fix test
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should wait on #17017 and be rebased once that's in.
These functions were only used in one place, and the code is simpler if we just directly do the work instead of using two separate functions.