Skip to content

Ignore jsdoc when inferring rest args in JavaScript #16696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2017
Merged

Ignore jsdoc when inferring rest args in JavaScript #16696

merged 1 commit into from
Jun 30, 2017

Conversation

rbuckton
Copy link
Contributor

When inferring a rest argument for a JavaScript function signature that does not already define one, ignore whether the function has existing JSDoc @param tags.

Fixes #15663

@rbuckton rbuckton requested a review from sandersn June 22, 2017 17:52
@rbuckton rbuckton added this to the TypeScript 2.4.2 milestone Jun 22, 2017
@rbuckton rbuckton merged commit 2a6aacd into master Jun 30, 2017
@rbuckton rbuckton deleted the fix15663 branch September 23, 2017 01:46
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sandersn sandersn sandersn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
TypeScript 2.5
Development

Successfully merging this pull request may close these issues.
3 participants
@rbuckton @sandersn @msftclas