Skip to content

Emit class annotation comment on downlevel classes #16631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2017
Merged

Emit class annotation comment on downlevel classes #16631

merged 1 commit into from
Aug 14, 2017

Conversation

rbuckton
Copy link
Contributor

This adds a /** @class */ comment when emitting ES6 classes down-level, except when --removeComments is supplied.

Fixes #13721

sandersn
sandersn approved these changes Jun 20, 2017
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as you are OK with the change to the tests. Was your objection in the bug issue to the amount of churn?

@rbuckton rbuckton added this to the TypeScript 2.5 milestone Jun 22, 2017
@AlgusDark AlgusDark mentioned this pull request Jun 24, 2017
Closed
@Koslun Koslun mentioned this pull request Jul 7, 2017
Closed
@DanielRosenwasser DanielRosenwasser merged commit ea7c7d3 into master Aug 14, 2017
@weswigham weswigham mentioned this pull request Aug 14, 2017
Merged
@DanielRosenwasser DanielRosenwasser mentioned this pull request Aug 15, 2017
Closed
@rbuckton rbuckton deleted the fix13721 branch September 23, 2017 01:46
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sandersn sandersn sandersn approved these changes

@DanielRosenwasser DanielRosenwasser DanielRosenwasser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
TypeScript 2.5
Development

Successfully merging this pull request may close these issues.
4 participants
@rbuckton @sandersn @DanielRosenwasser @msftclas