Report JSDoc syntax errors #16156
Merged
Report JSDoc syntax errors #16156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheetalkamat
approved these changes
May 31, 2017
|
I think this has caused the last two builds on Travis to fail. |
|
I thought the travis failures on this PR were due to node-stable upgrading to Node 8. |
|
The build error I looked at was for node 6--stable is passing. It looks like tslint is now checking es5.d.ts and finding lots of lint, specifically badly formatted jsdoc. But I think that is unrelated to this change, which only adds errors to js files when checkjs is on. |
|
Maybe --exclude is being ignored by something in the pipeline now? There is an explicit exclude for es5.d.ts. |
|
Yep, this is a bug in tslint 5.4.0 that is fixed in 5.4.1: |
|
Ah, thanks for investigating! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that JSDoc syntax errors are only reported for javascript files with
// @ts-checkturned on. Typescript files don't report these errors because Typescript only uses Jsdoc for documentation — it seems wrong to report syntax errors on parts of Jsdoc that aren't also being checked.Fixes #13371