Skip to content

Make "exclude" default to empty if "include" is present. #12350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
Nov 21, 2016
Merged

Make "exclude" default to empty if "include" is present. #12350

1 commit merged into from
Nov 21, 2016

Conversation

ghost
Copy link

@ghost ghost commented Nov 18, 2016

Fixes #12334.

We included several tests asserting the old behavior, so we should make sure this is what we really want.

@ghost ghost assigned rbuckton Nov 18, 2016
@ghost ghost merged commit 90ee161 into master Nov 21, 2016
@ghost ghost deleted the default_excludes branch November 21, 2016 20:23
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@rbuckton rbuckton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mhegazy @rbuckton @msftclas