Fix for #11719 - TSServer: JS files should display syntactic errors for TS syntax #11848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…only constructs from within a JavaScript file as syntactic errors.
mhegazy
suggested changes
Oct 27, 2016
| // For JavaScript files, we report semantic errors for using TypeScript-only | ||
| // constructs from within a JavaScript file as syntactic errors. | ||
| if (isSourceFileJavaScript(sourceFile) && !sourceFile.parseJavaScriptDiagnostics) { | ||
| sourceFile.parseJavaScriptDiagnostics = getJavaScriptSemanticDiagnosticsForFile(sourceFile); |
There was a problem hiding this comment.
change the name to getJavaScriptSyntacticDiagnosticsForFile
| // constructs from within a JavaScript file as syntactic errors. | ||
| if (isSourceFileJavaScript(sourceFile) && !sourceFile.parseJavaScriptDiagnostics) { | ||
| sourceFile.parseJavaScriptDiagnostics = getJavaScriptSemanticDiagnosticsForFile(sourceFile); | ||
| sourceFile.parseDiagnostics = sourceFile.parseDiagnostics.concat(sourceFile.parseJavaScriptDiagnostics); |
There was a problem hiding this comment.
i would not change the parseDiagnostics here.
| if (isSourceFileJavaScript(sourceFile) && !sourceFile.parseJavaScriptDiagnostics) { | ||
| sourceFile.parseJavaScriptDiagnostics = getJavaScriptSemanticDiagnosticsForFile(sourceFile); | ||
| sourceFile.parseDiagnostics = sourceFile.parseDiagnostics.concat(sourceFile.parseJavaScriptDiagnostics); | ||
| } |
There was a problem hiding this comment.
consider changing it to:
if (isSourceFileJavaScript(sourceFile))
if (!sourceFile.additionalSyntacticDiagnostics) {
sourceFile.additionalSyntacticDiagnostics = getJavaScriptAdditionalSyntacticDiagnosticsForFile(sourceFile);
}
return concatenate(sourceFile.additionalSyntacticDiagnostics, sourceFile.parseDiagnostics);
}
return sourceFile.parseDiagnostics;… has changed due to concatenation changes
mhegazy
approved these changes
Oct 28, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #11719 - TSServer: JS files should display syntactic errors for TS syntax
For JavaScript files, report semantic errors for using TypeScript-only constructs from within a JavaScript file as syntactic errors.