-
Notifications
You must be signed in to change notification settings - Fork 12.8k
[Transforms] Merge master 09/01 #10679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Avoid using the global name
Just cloning TS on travis takes 23 seconds on linux (68 seconds on mac), hopefully having it do a shallow clone will help. We don't rely on any tagging/artifacts from the travis servers which clone depth could impact, so this shouldn't impact anything other than build speed.
…arameter-constraints Correct this in tuple type parameter constraints
Use brand types to clear up confusion about entity name expressions
Optimize format of type list id strings used in maps
…pings": null` to disclude it from automatically included typings.
Allow `"typings": null`
Fix discriminated unions with primtive types
Speed up fourslash tests
Optimize performance of maps
Add `multiMapAdd` helper
…e_modules/@types" instead of just for "node_modules".
Hi @yuit, @rbuckton, For example, commit 3f6aa3f seems to have been merged with the previous PR already (in the squash commit), but is included in this PR again, as AFAIK for Git it looks as if the last merged commit from the Thank you! |
Factor public type definitions out of services.ts into services/types.ts
Use explicit pairs `verify.goToDefinition([["a", "b"], ["c", "d"]])` instead of `verify.goToDefinition("a", "b", "c", "d")`. Also provide an option `verify.goToDefinition({ a: "b", c: "d" })` for cases where the starts are not theirselves lists.
Search for `node_modules` in parent directories when getting type roots.
…d be node_modules/@types, not just node_modules
Simplify go-to-definition tests
👍 |
Fix call signature caching
Add `multiMapRemove` helper
Default type roots when host.directoryExists is not implemented shoul…
@kpreisser Thanks for raising this up! I didn't saw your original comment until now and wasn't awared of the different. Now that I know I will not squash my commit. I normally do so when I merge to |
Great, thanks! |
The last three comments are the ones that will need review