Allow "typings": null
#10303
Merged
Allow "typings": null
#10303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (host.directoryExists && host.getDirectories) { | ||
| const typeRoots = getEffectiveTypeRoots(options, host); | ||
| if (typeRoots) { | ||
| for (const root of typeRoots) { | ||
| if (host.directoryExists(root)) { | ||
| for (const typeDirectivePath of host.getDirectories(root)) { | ||
| // Return just the type directive names | ||
| result = result.concat(getBaseFileName(normalizePath(typeDirectivePath))); | ||
| const normalized = normalizePath(typeDirectivePath) |
There was a problem hiding this comment.
Not sure why we normalize here since getDirectories should produce a list of plain directory names, not full paths.
ghost
force-pushed
the
not_needed_types
branch
from
d0a7d19 to
a55b9cc
Compare
…pings": null` to disclude it from automatically included typings.
ghost
force-pushed
the
not_needed_types
branch
from
a55b9cc to
df739fd
Compare
|
👍 |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10291.
Also fixes #10295.
This solution may not be ideal because it results in us generally parsing the
package.jsonfiles 2 times; once when we read to determine whether to include the typings, and if so, again later on when we actually resolve the typings.