Set isNewIdentifierLocation to true for JavaScript files #10391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4247,7 +4247,7 @@ namespace ts { | |||
| addRange(entries, keywordCompletions); | |||
| } | |||
|
|
|||
| return { isMemberCompletion, isNewIdentifierLocation, entries }; | |||
| return { isMemberCompletion, isNewIdentifierLocation: isSourceFileJavaScript(sourceFile) ? true : isNewIdentifierLocation, entries }; | |||
There was a problem hiding this comment.
isNewIdentifierLocation || isSourceFileJavaScript(sourceFile)
|
👍 with a minor suggestion |
|
Thanks - like the suggestion. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Completion list auto-select is leading to a poor editing experience in JS files for Salsa
ex: var test = "test";
test.at auto-selects test.charAt
This is fine for TS where all completion items are high confidence. For JS, the completion lists will often contain low confidence items (identifiers in file) so auto-selecting is undesirable.
Fix: Always set isNewIdentifierLocation to true for JavaScript files. This ensures that for JS completions IsBuilder is true and auto-select is disabled.