Make baselines faster by not writing out unneeded files #10213
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes here
The first is to not write out baseline files to
/local
when the content is already identical to what's in/reference
. Instead, we write out new files when they've changed, and write.delete
files when the file exists in/reference
but not in/local
The second is to update the
baseline-accept
tasks to simply copy with overwrite, plus treat.delete
files specially so they delete the destination file. These are now basically "soft by default" so you can run arbitrary subsets of tests andbaseline-accept
without having to worry about nuking yourreference
folder.Locally, these brought the total time to run the 'conformance' suite from 1m33s to 0m54s. Might even be a bigger gain on non-SSD machines (not sure what travis is using).