Skip to content

Don't allow properties inherited from Object to be automatically included in TSX attributes #10153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Aug 5, 2016

Conversation

ghost
Copy link

@ghost ghost commented Aug 4, 2016

We were using unprotected accesses to a table of property names, which I assume was mistaken. We now generate an error if a TSX element requires e.g. a toString property and it is not explicitly provided.

@RyanCavanaugh
Copy link
Member

👍

@ghost ghost merged commit b54aec1 into master Aug 5, 2016
@ghost ghost deleted the tsx_toString branch August 5, 2016 12:57
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants