Skip to content

Syntactic classification isn't working correctly with JSDoc comments #9650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jramsay opened this issue Jul 12, 2016 · 0 comments
Closed

Syntactic classification isn't working correctly with JSDoc comments #9650

jramsay opened this issue Jul 12, 2016 · 0 comments
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue
Milestone
TypeScript 2.0.2

Comments

@jramsay
Copy link
Member

jramsay commented Jul 12, 2016

Issue: Syntactic classification isn't working correctly with JSDoc comments. In dev mode you'll see a repeated debug.Assert (VS) in tryClassifyNode due to tokenWidth < 0.

This is related to recent jsDoc comment changes. Specifically this change:

jsdoc

Version

capture

Code

durandal
@zhengbli zhengbli added this to the TypeScript 2.0.1 milestone Jul 12, 2016
@mhegazy mhegazy added the Bug A bug in TypeScript label Jul 13, 2016
@zhengbli zhengbli mentioned this issue Aug 18, 2016
Merged
@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Aug 22, 2016
@zhengbli zhengbli mentioned this issue Aug 25, 2016
Merged
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue
Projects
None yet
Milestone
TypeScript 2.0.2
Development

No branches or pull requests
3 participants
@zhengbli @mhegazy @jramsay